Support running executables from Bundler gems and project-local scripts#141
Support running executables from Bundler gems and project-local scripts#141jkutner merged 5 commits intojruby:masterfrom bjeanes:master
Conversation
|
excellent -I'm really glad |
|
I plan to test it without bundler too. |
There was a problem hiding this comment.
I had to make this change to get the *.java files in master branch to compile but it is not directly related to this change. Let me know if you'd like me to break that out as a separate PR.
init.rb expects $servelet_container to be set. Luckily, it uses ||= to set those env variables. To move forward, I'm pre-setting them so that $servelet_container isn't used (since it is not set), but this could/should be done much nicer.
|
@kares as far as I know this is working as expected. There aren't any automated tests that I can find around this functionality but the general expected outcomes work for me and the existing tests pass (though Travis seems to be consistently running this project, so I can't speak for the full build matrix). I'd like to do a refactoring of the "runnable" responsibilities entirely (as well as make it available in JarMain as well as WarMain) but they are probably best served as different pull requests. |
|
Hey Bo, yeah it seems all fine. There sure are no tests (besides the original code being a "draft" :)) I only did testing locally with a Rails app as well ... maybe @BanzaiMan can merge this than (refactoring to be done on another PR) ? |
|
@kares ok. Make sure you tested after running |
|
@kares, have you seen those Travis failures before? I am not able to reproduce them locally or reason about what part of my change could have caused them to fail. |
|
This is littered near the failures in the output on Travis: A cursory glance at the specs make it seem like it is bundling the local git repo as a gem in a test. My (still unsubstantiated) theory is that Travis has started only doing shallow clones of tested repositories to lessen network load. |
|
bump |
|
This looks extremely useful, and not having this is one of our largest pain points in our jruby deploy right now (not having a simple solution for utility servers). So I 👍 this. |
|
I've fixed the ci failures. working on getting this merged now. |
|
👏 |
|
I'd really like to see some specs for this. It would also be nice to refactor the |
|
I completely agree. There wasn't a real precedent for this stuff, but am happy to help out. I actually really want to do the refactoring but held back both because I didn't want this PR to be rejected due to too many changes and because of a lack of test infrastructure. If we can agree on a structure for that aspect, I'd be more than happy to help give these aspects a revamp. |
|
Oh also @jkutner I didn't commit the compiled results (simply so as not to add repo weight until the changes were accepted). Be sure to do a compilation before any new gem builds! |
This feature needs to be cleaned up and refactored, but that would require refactoring some other pieces. If this is merged, I'm going to do that in a separate pull request so we can have a more critical look at the effect of the refactoring, since none of the Java portions of this gem have any automated tests.
This change enables the following:
It builds on the work from #130 and #136.